Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @oshogbo)

Documentation/manpages/scag-setup.rst line 32 at r1 (raw file):

.. option:: --gramine_unstable

   Use an pre-release version of Gramine.

an -> a

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (3 more required), not enough approvals from different teams (2 more required, approved so far: ) (waiting on @dimakuv)

Documentation/manpages/scag-setup.rst line 32 at r1 (raw file):

Done.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel)

Reviewable status: all files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @oshogbo)

Documentation/manpages/scag-setup.rst line 127 at r2 (raw file):

    [gramine]
    passthrough_env = []
    gramine_unstable = false

Setup/config is a wrong level for this feature. Say I'm Very Important Customer and I have Very Important Workload, I'd want to test for new release, so I probably won't re-setup it.

Also I still think if we could make it automatic, without having to set a switch/flag. Can we detect it at the scag-build` time somehow? Like to check if the installed Gramine version is stable vs unstable?

graminescaffolding/templates/sources.list line 8 at r2 (raw file):

{% else %}
deb https://packages.gramineproject.io/ bookworm main
{% endif %}

Suggestion:

deb https://packages.gramineproject.io/ {% if gramine_unstable %}unstable-{% endif %}bookworm main

Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv and @woju)

Documentation/manpages/scag-setup.rst line 127 at r2 (raw file):

Hym. I think that this actually a good level. You can have multiple configuration files depending on the releases or whatever you want to build. Then you can simply use scag-build -f to switch between different configurations.

This defines how scag behaves. And I think that the config options like codenmae, stable/unstable etc should be defined on the config level.

I do not understand why he won't re-setup it? The re-setup phase isn't complicated.
Either he rests up it and sets use a proper flag or copies the existing configuration and he changes the version.

I thought about "automatic detection" but this can be error-prone, also you might have oos builds installed locally (compatible with the version inside the gramine).

I don't see a benefit of having it as a build flag as this will somehow be lost after the build. Otherwise, you can say which config file you used to build a project as a whole without defining the additional build flag that was used.

graminescaffolding/templates/sources.list line 8 at r2 (raw file):

{% else %}
deb https://packages.gramineproject.io/ bookworm main
{% endif %}

Done.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @oshogbo)

Documentation/manpages/scag-setup.rst line 127 at r2 (raw file):

The problem is, this needs to be 1:1 correlated with the gramine package version that is installed on the system. You can't just switch this with -f without reinstalling Gramine, and vice versa, if you reinstall gramine, but don't change this config option (or resetup), you'll get an error. So ideally I would like this thing automatic, without switches or configs at all.

graminescaffolding/templates/sources.list line 8 at r2 (raw file):

Thanks!

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @oshogbo)